Open
Conversation
Author
|
I was aware of the failing formatting check, but that is existing bad formatting and I was loathe to change formatting outside of code I was modifying myself. |
Member
|
Can you rebase your PR? thanks |
chris114782
force-pushed
the
feature/separate-git-directory-support
branch
from
2694243 to
71b85b8
Compare
tsterker
reviewed
Feb 26, 2024
| if (!preg_match('/^gitdir: ?(.+)$/', file_get_contents($realGitDir . '/.git'), $matches)) { | ||
| throw new InvalidArgumentException(sprintf('Directory "%s" contains a .git file, but it is not in the expected format', $realGitDir)); | ||
| } | ||
| $foundGitPath = realpath($realGitDir . DIRECTORY_SEPARATOR . $matches[1]); |
There was a problem hiding this comment.
@chris114782 This assumes that the gitdir is a relative path, which might not be true.
Author
There was a problem hiding this comment.
I'll try and take a look this weekend, it's been a few months (nearly a year now!) since I looked at this and I need to get my head back into it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #200 I highlighted that the library does not support submodules.
This is because in a submodule does not store its .git folder inside the checked out repository, instead .git is a file that has a reference to the actual location of the .git directory.
This is documented here
You can manually reproduce this by doing
git clone --separate-git-dir=/somewhere/else your-repo-urlThis PR adds support for such a set up by detecting that .git is a file instead of a directory and attempting to read the path to the real directory from it.